<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><br><br>Sent from my iPhone</div><div><br>On Dec 15, 2015, at 11:50 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">I think I fixed that const qualified issue with r255678. I still have warnings from ppltasks.h, which is this connect issue:<div><a href="https://connect.microsoft.com/VisualStudio/feedback/details/1132688/ppltasks-h-does-not-compile-cleanly">https://connect.microsoft.com/VisualStudio/feedback/details/1132688/ppltasks-h-does-not-compile-cleanly</a><br></div><div><br></div><div>I think we should ban inclusions of <future> in LLVM and make a wrapper header that uses pragmas to disable warnings in <future> transitive includes.</div></div></div></blockquote><div><br></div><div>#include "llvm/Support/future.h"?</div><div>I can give a try at that later today, but since I can't validate with MSVC it might take a few tentatives, so I don't mind if someone else do it.</div><div><br></div><div>Thanks,</div><div><br></div><div>Mehdi</div><br><blockquote type="cite"><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 15, 2015 at 12:50 PM, Mehdi Amini via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><span></span></div><div><span>Oh ok you are talking about this one:</span></div><span class=""><div><br></div><div><blockquote type="cite"><font color="#000000"><span style="background-color:rgba(255,255,255,0)">C:\llvm\rw\include\llvm/Support/ThreadPool.h(73): error C3848: expression having type 'const std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>' would lose some const-volatile qualifiers in order to call 'void std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>::operator ()<>(void)'<br></span></font></blockquote><blockquote type="cite"><font color="#000000"><span style="background-color:rgba(255,255,255,0)">1> with</span></font></blockquote><br></div></span><div>It was not clear in the sea of warning (probably because I'm used to Clang like warnings).</div><div><br></div><div>I'm away of the office right now, I'll try to look at it if you don't figure out, but no ETA.</div><div><br></div><div>Thanks,</div><div><br></div><div>Mehdi</div><div><br></div><div><br><span></span><br><span>Sent from my iPhone</span><span class=""><br><span></span><br><span>On Dec 15, 2015, at 5:59 AM, Kuperstein, Michael M <<a href="mailto:michael.m.kuperstein@intel.com" target="_blank">michael.m.kuperstein@intel.com</a>> wrote:</span><br><span></span><br><blockquote type="cite"><blockquote type="cite"><span>C:\llvm\rw\include\llvm/Support/ThreadPool.h(73): error C3848: expression having type 'const std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>' would lose some const-volatile qualifiers in order to call 'void std::_Bind<true,void,void (__cdecl *const )(std::atomic_int &,int),_Ty,size_t &>::operator ()<>(void)'</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>1> with</span><br></blockquote></blockquote></span></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</div></blockquote></body></html>