[PATCH] D15474: AMDGPU/SI: Add llvm.amdgcn.v.interp.p[12] intrinsics

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUIntrinsicExpander.cpp:1
@@ +1,2 @@
+//===-- AMDGPUIntrinsicExpanderPass.cpp ---------------------------------------===//
+//
----------------
arsenm wrote:
> Why is this easier than handling the differences during intrinsic lowering?
I would like to stop using the intrinsics like fs.interp which are more like library calls, so I don't want to add them to the public IntrinsicsAMDGPU.td file.  Having an IR expansion pass here means I only need to handle the lower-level intrinsics in isSourceOfDivergence(), and I don't need to use AMGPUInstrinsicInfo to look up intrinsic names.


http://reviews.llvm.org/D15474