[PATCH] D15464: Add a C++11 ThreadPool implementation in LLVM

[David Blaikie via llvm-commits]

On Sat, Dec 12, 2015 at 2:58 PM, Mehdi AMINI via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> joker.eph closed this revision.
> joker.eph marked 2 inline comments as done.
> joker.eph added a comment.
>
> r255444
>
>
> ================
> Comment at: lib/Support/ThreadPool.cpp:139
> @@ +138,3 @@
> +ThreadPool::~ThreadPool() {
> +  EnableFlag = false;
> +  wait();
> ----------------
> tejohnson wrote:
> > Is this just for completeness? It doesn't look like this flag is used
> when ! LLVM_ENABLE_THREADS.
> It is to silent a compiler warning about "member variable not used" when
> compiling with LLVM_ENABLE_THREAD=OFF
>

Perhaps a more explicit cast to void, or ifdef out the variable instead?


>
>
> http://reviews.llvm.org/D15464
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151213/fd0c9d2f/attachment.html>