<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Dec 12, 2015 at 2:58 PM, Mehdi AMINI via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joker.eph closed this revision.<br>
joker.eph marked 2 inline comments as done.<br>
joker.eph added a comment.<br>
<br>
r255444<br>
<span class=""><br>
<br>
================<br>
Comment at: lib/Support/ThreadPool.cpp:139<br>
@@ +138,3 @@<br>
+ThreadPool::~ThreadPool() {<br>
+  EnableFlag = false;<br>
+  wait();<br>
----------------<br>
</span><span class="">tejohnson wrote:<br>
> Is this just for completeness? It doesn't look like this flag is used when ! LLVM_ENABLE_THREADS.<br>
</span>It is to silent a compiler warning about "member variable not used" when compiling with LLVM_ENABLE_THREAD=OFF<br></blockquote><div><br>Perhaps a more explicit cast to void, or ifdef out the variable instead?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="http://reviews.llvm.org/D15464" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15464</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>