[PATCH] D14429: [mips][microMIPS][DSP] Implement PACKRL.PH, PICK.PH, PICK.QB, SHILO, SHILOV and WRDSP instructions
Zlatko Buljan via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 04:17:37 PST 2015
zbuljan updated this revision to Diff 42158.
zbuljan added a comment.
Replaced Match_UImm7_0_Report_UImm with plain Match_UImm7_0.
Removed Match_UImm10_0_Report_UImm and used Match_UImm10_0 instead.
Error messages are updated accordingly.
SuperClass members of ConstantUImm7AsmOperandClass, ConstantSImm6AsmOperandClass and ConstantUImm5AsmOperandClass are updated so instructions can be matched in the correct order.
ConstantSImmAsmOperandClass and simm6 operand definition are moved to MipsInstrFormats.td (near the definition of ConstantUImmAsmOperandClass).
Added invalid-wrong-error.s for microMIPS DSP.
Problematic test cases for WRDSP instruction moved from invalid.s to invalid-wrong-error.s (they are correctly rejected but currently wrong error message is shown).
http://reviews.llvm.org/D14429
Files:
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
lib/Target/Mips/MicroMipsDSPInstrFormats.td
lib/Target/Mips/MicroMipsDSPInstrInfo.td
lib/Target/Mips/MipsDSPInstrFormats.td
lib/Target/Mips/MipsDSPInstrInfo.td
lib/Target/Mips/MipsInstrInfo.td
test/MC/Disassembler/Mips/dsp/valid-el.txt
test/MC/Disassembler/Mips/micromips-dsp/valid.txt
test/MC/Disassembler/Mips/micromips-dspr2/valid.txt
test/MC/Mips/dsp/invalid.s
test/MC/Mips/dsp/valid.s
test/MC/Mips/dspr2/valid.s
test/MC/Mips/micromips-dsp/invalid-wrong-error.s
test/MC/Mips/micromips-dsp/invalid.s
test/MC/Mips/micromips-dsp/valid.s
test/MC/Mips/micromips-dspr2/valid.s
test/MC/Mips/micromips-invalid.s
test/MC/Mips/micromips32r6/invalid.s
test/MC/Mips/mips32r6/invalid.s
test/MC/Mips/mips64r6/invalid.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14429.42158.patch
Type: text/x-patch
Size: 38506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/e92674ca/attachment.bin>
More information about the llvm-commits
mailing list