[PATCH] D15270: PassManagerInternal: remove unused parameters. NFC.

[Philip Reames via llvm-commits]

I think this patch - and the others of similar vein you've posted - are 
flat out a bad idea.  They diminish readability for no gain.  Do you 
have a good argument for why unnamed parameters are a good idea?

Philip

On 12/06/2015 03:44 PM, Visoiu Mistrih Francis via llvm-commits wrote:
> thegameg created this revision.
> thegameg added a reviewer: llvm-commits.
> thegameg set the repository for this revision to rL LLVM.
>
> Repository:
>    rL LLVM
>
> http://reviews.llvm.org/D15270
>
> Files:
>    include/llvm/IR/PassManagerInternal.h
>
> Index: include/llvm/IR/PassManagerInternal.h
> ===================================================================
> --- include/llvm/IR/PassManagerInternal.h
> +++ include/llvm/IR/PassManagerInternal.h
> @@ -122,7 +122,7 @@
>       return *this;
>     }
>
> -  PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *AM) override {
> +  PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *) override {
>       return Pass.run(IR);
>     }
>     StringRef name() override { return PassT::name(); }
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151207/8f7d6fca/attachment.html>