<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">I think this patch - and the others of
similar vein you've posted - are flat out a bad idea. They
diminish readability for no gain. Do you have a good argument for
why unnamed parameters are a good idea?<br>
<br>
Philip<br>
<br>
On 12/06/2015 03:44 PM, Visoiu Mistrih Francis via llvm-commits
wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-ngmhc6qcct7mog7tiasc-req@reviews.llvm.org"
type="cite">
<pre wrap="">thegameg created this revision.
thegameg added a reviewer: llvm-commits.
thegameg set the repository for this revision to rL LLVM.
Repository:
rL LLVM
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D15270">http://reviews.llvm.org/D15270</a>
Files:
include/llvm/IR/PassManagerInternal.h
Index: include/llvm/IR/PassManagerInternal.h
===================================================================
--- include/llvm/IR/PassManagerInternal.h
+++ include/llvm/IR/PassManagerInternal.h
@@ -122,7 +122,7 @@
return *this;
}
- PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *AM) override {
+ PreservedAnalysesT run(IRUnitT &IR, AnalysisManager<IRUnitT> *) override {
return Pass.run(IR);
}
StringRef name() override { return PassT::name(); }
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>