[PATCH] D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting

[Tim Northover via llvm-commits]

t.p.northover added inline comments.

================
Comment at: lib/Target/ARM/ARM.td:389
@@ -382,1 +388,3 @@
 
+def ARMv8mBaseline : Architecture<"armv8-m.base", "ARMv8mBaseline",
+                                                      [HasV8MBaselineOps,
----------------
bsmith wrote:
> t.p.northover wrote:
> > Since we're planning on these to be exposed via Clang, I think we should test that the instruction categories we want really are accepted (by llvm-mc say).
> > 
> > No need to go overboard, but a line or two from the obvious sets would be good.
> The later patches add such tests as they go along, is what they do sufficient?
It doesn't look like the other patches will test that FeatureNoARM, FeatureDB, FeatureV7Exclusives or FeatureAcquireRelease are part of these new armv8-m archs.

HWDiv probably gets tested with the division patch, and MClass by the extra sysregs you're adding.


Repository:
  rL LLVM

http://reviews.llvm.org/D15275