[PATCH] D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting

Bradley Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 07:17:31 PST 2015


bsmith added inline comments.

================
Comment at: lib/Target/ARM/ARM.td:389
@@ -382,1 +388,3 @@
 
+def ARMv8mBaseline : Architecture<"armv8-m.base", "ARMv8mBaseline",
+                                                      [HasV8MBaselineOps,
----------------
t.p.northover wrote:
> Since we're planning on these to be exposed via Clang, I think we should test that the instruction categories we want really are accepted (by llvm-mc say).
> 
> No need to go overboard, but a line or two from the obvious sets would be good.
The later patches add such tests as they go along, is what they do sufficient?


Repository:
  rL LLVM

http://reviews.llvm.org/D15275





More information about the llvm-commits mailing list