[PATCH] D14712: [mips][ias] Range check uimm5 operands and fix several bugs this revealed.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 03:27:36 PST 2015


dsanders added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1031
@@ +1030,3 @@
+  bool isScaledUImm() const {
+    return (isImm() && isConstantImm() &&
+            isShiftedUInt<Bits, ShiftLeftAmount>(getConstantImm()));
----------------
vkalintiris wrote:
> I don't think we need isImm() because isConstantImm() calls it internally.
I agree. I'll fix this in the commit


http://reviews.llvm.org/D14712





More information about the llvm-commits mailing list