[PATCH] D14712: [mips][ias] Range check uimm5 operands and fix several bugs this revealed.
Vasileios Kalintiris via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 07:24:26 PST 2015
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1031
@@ +1030,3 @@
+ bool isScaledUImm() const {
+ return (isImm() && isConstantImm() &&
+ isShiftedUInt<Bits, ShiftLeftAmount>(getConstantImm()));
----------------
I don't think we need isImm() because isConstantImm() calls it internally.
http://reviews.llvm.org/D14712
More information about the llvm-commits
mailing list