[PATCH] D14991: [ELF/AArch64] Print a diagnostic message if nonzero addend is used in a GOT relocation.

[Rui Ueyama via llvm-commits]

They are examples in which we create invalid outputs for broken inputs. My
point still stands. It is not always unacceptable to create invalid outputs
in such case.

On Wed, Nov 25, 2015 at 11:38 AM, Igor Kudrin <ikudrin.dev at gmail.com> wrote:

> ikudrin added a comment.
>
> Your first example violates the expected format of archive, if I
> understand it right. We may rely on underlying library and its checks in
> that case.
>
> I have no comment for the second example. May be it's hard to imagine
> other command or something.
>
> But in this case, I just wanted to detect our own ABI violation. Not to
> implement that case, as it might be rare, just detect. And I wanted to be
> honest with our users and not generate broken result from an ABI-compliant
> input if it can be avoided.
>
>
> http://reviews.llvm.org/D14991
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151125/884a18d5/attachment.html>