[PATCH] D14991: [ELF/AArch64] Print a diagnostic message if nonzero addend is used in a GOT relocation.

[Igor Kudrin via llvm-commits]

ikudrin added a comment.

Your first example violates the expected format of archive, if I understand it right. We may rely on underlying library and its checks in that case.

I have no comment for the second example. May be it's hard to imagine other command or something.

But in this case, I just wanted to detect our own ABI violation. Not to implement that case, as it might be rare, just detect. And I wanted to be honest with our users and not generate broken result from an ABI-compliant input if it can be avoided.


http://reviews.llvm.org/D14991