[PATCH] D14900: [mips] SelectionDAGISel subclasses now follow the optimization level.

Vladimir Radosavljevic via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 07:42:50 PST 2015


vradosavljevic added a comment.

In http://reviews.llvm.org/D14900#294537, @dsanders wrote:

> I'm not sure what to do about the test. I've preserved what it was really testing for now but I believe the intention was to test SelectionDAG and not FastISel. Unfortunately, reverting the original change that added this test (http://reviews.llvm.org/rL237153) does not change the output of SelectionDAG.
>
> Added the author and commit-er for their opinion.


In this test we're checking that register scavenging spill slot is close to $fp, but this commit (http://reviews.llvm.org/rL237153) changed the essence of this test. Any reason why this happened?


http://reviews.llvm.org/D14900





More information about the llvm-commits mailing list