[PATCH] D14812: AVX-512: Fixed COPY_TO_REGCLASS for mask registers

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4298
@@ +4297,3 @@
+static
+unsigned copyPhysRegOpcode_AVX512_BW(unsigned& DestReg, unsigned& SrcReg) {
+  if (MaskRegClassContains(SrcReg) && MaskRegClassContains(DestReg))
----------------
igorb wrote:
> Does DestReg/SrcReg should be set to  i32/i64 for kmovd/kmovg ?
Otherwise we can use KMOVW

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4303
@@ +4302,3 @@
+    return X86::KMOVDrk;
+  if (MaskRegClassContains(SrcReg) && X86::GR64RegClass.contains(DestReg))
+    return X86::KMOVQrk;
----------------
igorb wrote:
>  I think X86::KMOVQrk and X86::KMOVQkr is invalid in 32bit mode and  KMOVD should be used instead.
We don't have GR64 in 32-bit mode.


Repository:
  rL LLVM

http://reviews.llvm.org/D14812