[PATCH] D14812: AVX-512: Fixed COPY_TO_REGCLASS for mask registers
Igor Breger via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 02:55:41 PST 2015
igorb added inline comments.
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4298
@@ +4297,3 @@
+static
+unsigned copyPhysRegOpcode_AVX512_BW(unsigned& DestReg, unsigned& SrcReg) {
+ if (MaskRegClassContains(SrcReg) && MaskRegClassContains(DestReg))
----------------
Does DestReg/SrcReg should be set to i32/i64 for kmovd/kmovg ?
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4303
@@ +4302,3 @@
+ return X86::KMOVDrk;
+ if (MaskRegClassContains(SrcReg) && X86::GR64RegClass.contains(DestReg))
+ return X86::KMOVQrk;
----------------
I think X86::KMOVQrk and X86::KMOVQkr is invalid in 32bit mode and KMOVD should be used instead.
Repository:
rL LLVM
http://reviews.llvm.org/D14812
More information about the llvm-commits
mailing list