[PATCH] D14713: [ELF2] - Optimization for R_X86_64_GOTTPOFF relocation.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 16:47:53 PST 2015


rafael added inline comments.

================
Comment at: ELF/Target.cpp:371
@@ +370,3 @@
+  if (Loc - 3 < BufStart)
+    error("Tls relocation optimization fail, buffer overrun !");
+  uint8_t *Prefix = &Loc[-3];
----------------
Please add a test for this.

It is important to show that we can actually get here with broken input.


http://reviews.llvm.org/D14713





More information about the llvm-commits mailing list