[PATCH] D14713: [ELF2] - Optimization for R_X86_64_GOTTPOFF relocation.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: test/elf2/tls-opt.s:2
@@ +1,3 @@
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+// RUN: ld.lld2 -e main %t.o -o %t1
+// RUN: llvm-readobj -r %t1 | FileCheck --check-prefix=NORELOC %s
----------------
Just create a _start and drop the "-e main"

================
Comment at: test/elf2/tls-opt.s:13
@@ +12,3 @@
+// DISASM-NEXT: 11007: 49 c7 c7 f8 ff ff ff movq $-8, %r15
+// DISASM-NEXT: 1100e: 48 8d 80 f8 ff ff ff leaq -8(%rax), %rax
+// DISASM-NEXT: 11015: 4d 8d bf f8 ff ff ff leaq -8(%r15), %r15
----------------
Do you really need the binary content? The text should be sufficient, no? I.E.:

// DISASM-NEXT: 11000: {{.*}} movq $-8, %rax


http://reviews.llvm.org/D14713