[PATCH] D14788: Fix bug 24715

[Philip Reames via llvm-commits]

LGTM.

Looking a related code, it looks like we're failing to consider the 
return value of the same function at it's other call site.  Any interest 
in fixing that too?

Philip

On 11/18/2015 02:17 PM, Wenxiang Qiu via llvm-commits wrote:
> vincentqiuuu created this revision.
> vincentqiuuu added a reviewer: joker.eph.
> vincentqiuuu added a subscriber: llvm-commits.
>
> Fix for https://llvm.org/bugs/show_bug.cgi?id=24715
> Boolean flag Changed in GVN::performPRE(Function &F) is not correctly updated.
>
> http://reviews.llvm.org/D14788
>
> Files:
>    lib/Transforms/Scalar/GVN.cpp
>
> Index: lib/Transforms/Scalar/GVN.cpp
> ===================================================================
> --- lib/Transforms/Scalar/GVN.cpp
> +++ lib/Transforms/Scalar/GVN.cpp
> @@ -2709,7 +2709,7 @@
>                                 BE = CurrentBlock->end();
>            BI != BE;) {
>         Instruction *CurInst = &*BI++;
> -      Changed = performScalarPRE(CurInst);
> +      Changed |= performScalarPRE(CurInst);
>       }
>     }
>   
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151118/a6164004/attachment.html>