<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
LGTM. <br>
<br>
Looking a related code, it looks like we're failing to consider the
return value of the same function at it's other call site. Any
interest in fixing that too?<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 11/18/2015 02:17 PM, Wenxiang Qiu
via llvm-commits wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-5if5soed3rjvdptavz36-req@reviews.llvm.org"
type="cite">
<pre wrap="">vincentqiuuu created this revision.
vincentqiuuu added a reviewer: joker.eph.
vincentqiuuu added a subscriber: llvm-commits.
Fix for <a class="moz-txt-link-freetext" href="https://llvm.org/bugs/show_bug.cgi?id=24715">https://llvm.org/bugs/show_bug.cgi?id=24715</a>
Boolean flag Changed in GVN::performPRE(Function &F) is not correctly updated.
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D14788">http://reviews.llvm.org/D14788</a>
Files:
lib/Transforms/Scalar/GVN.cpp
Index: lib/Transforms/Scalar/GVN.cpp
===================================================================
--- lib/Transforms/Scalar/GVN.cpp
+++ lib/Transforms/Scalar/GVN.cpp
@@ -2709,7 +2709,7 @@
BE = CurrentBlock->end();
BI != BE;) {
Instruction *CurInst = &*BI++;
- Changed = performScalarPRE(CurInst);
+ Changed |= performScalarPRE(CurInst);
}
}
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>