[PATCH] D14730: [Aarch64] Add cost for missing extensions.

[Matthew Simpson via llvm-commits]

mssimpso added inline comments.

================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.cpp:208
@@ +207,3 @@
+    { ISD::SIGN_EXTEND, MVT::v8i32,  MVT::v8i16, 2 },
+    { ISD::SIGN_EXTEND, MVT::v4i64,  MVT::v4i32, 2 },
+    { ISD::SIGN_EXTEND, MVT::v4i64,  MVT::v4i16, 3 },
----------------
sbaranga wrote:
> A small style issue: it would be nice to have a consistent order in this table. The logic for the ordering of the costs above doesn't match the one for the costs below.
> 
> FWIW I think the costs for the extensions between legal types (of size 64 or 128) was already 1 from the generic logic, but I think it's ok to have them explicitly specified here.
Nice catch. I'd rather not add extra lines of code that we don't need, so I'll remove the entries I created that are already covered by the generic logic. I'll also insert the new entries according to the existing sorting.


http://reviews.llvm.org/D14730