[PATCH] D14730: [Aarch64] Add cost for missing extensions.

[silviu.baranga@arm.com via llvm-commits]

sbaranga added a comment.

Thanks! I think this generally looks good and we only need some performance data.

-Silviu


================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.cpp:208
@@ +207,3 @@
+    { ISD::SIGN_EXTEND, MVT::v8i32,  MVT::v8i16, 2 },
+    { ISD::SIGN_EXTEND, MVT::v4i64,  MVT::v4i32, 2 },
+    { ISD::SIGN_EXTEND, MVT::v4i64,  MVT::v4i16, 3 },
----------------
A small style issue: it would be nice to have a consistent order in this table. The logic for the ordering of the costs above doesn't match the one for the costs below.

FWIW I think the costs for the extensions between legal types (of size 64 or 128) was already 1 from the generic logic, but I think it's ok to have them explicitly specified here.


http://reviews.llvm.org/D14730