[PATCH] D14622: [compiler-rt] [tsan] Enable intercept setjmp/longjmp for AArch64
Alexey Samsonov via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 11:49:44 PST 2015
samsonov added inline comments.
================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:454
@@ -453,2 +453,3 @@
uptr mangled_sp = env[2];
#else
+# ifdef __aarch64__
----------------
zatrazz wrote:
> samsonov wrote:
> > ```
> > # elif defined(__aarch64__)
> > uptr mangled_sp = env[13];
> > #else
> > uptr mangled_sp = env[6];
> > #endif
> > ```
> Wouldn't be better:
>
> ```
> #elif defined(SANITIZER_LINUX)
> # ifdef __aarch64__
> uptr mangled_sp = env[13];
> #else
> uptr mangled_sp = env[6];
> #endif
> ```
>
> ?
Okay (but please make sure indentation of #directives is fine).
http://reviews.llvm.org/D14622
More information about the llvm-commits
mailing list