[PATCH] D14622: [compiler-rt] [tsan] Enable intercept setjmp/longjmp for AArch64

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 04:07:57 PST 2015


zatrazz added inline comments.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:454
@@ -453,2 +453,3 @@
   uptr mangled_sp = env[2];
 #else
+# ifdef __aarch64__
----------------
samsonov wrote:
> ```
>   # elif defined(__aarch64__)
>     uptr mangled_sp = env[13];
>   #else
>     uptr mangled_sp = env[6];
>   #endif
> ```
Wouldn't be better:

```
#elif defined(SANITIZER_LINUX)
# ifdef  __aarch64__
  uptr mangled_sp = env[13];
#else
  uptr mangled_sp = env[6];
#endif
```

?


http://reviews.llvm.org/D14622





More information about the llvm-commits mailing list