[PATCH] D14589: sancov test suite

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 11:04:38 PST 2015


aizatsky added inline comments.

================
Comment at: tools/sancov/sancov.cc:230
@@ +229,3 @@
+        // Don't strip prefix if we only have a single file.
+        if (FileName.size() < FilePrefix.size())
+          FileName = FileName.substr(FilePrefix.size());
----------------
samsonov wrote:
> Shouldn't it be
>   if (FileName.size() > FilePrefix.size())
> ?
Nice catch. I guess I need a multi-file test to properly check it. Hold on.


http://reviews.llvm.org/D14589





More information about the llvm-commits mailing list