[PATCH] D14589: sancov test suite

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 11:03:10 PST 2015


samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

Looks fine, but please check this:


================
Comment at: tools/sancov/sancov.cc:230
@@ +229,3 @@
+        // Don't strip prefix if we only have a single file.
+        if (FileName.size() < FilePrefix.size())
+          FileName = FileName.substr(FilePrefix.size());
----------------
Shouldn't it be
  if (FileName.size() > FilePrefix.size())
?


http://reviews.llvm.org/D14589





More information about the llvm-commits mailing list