[lld] r252716 - Simplify. NFC.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 09:43:06 PST 2015


Fixed, thanks.



On 11 November 2015 at 11:26, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> On Wed, Nov 11, 2015 at 1:57 AM, Rafael Espindola via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: rafael
>> Date: Wed Nov 11 03:57:08 2015
>> New Revision: 252716
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=252716&view=rev
>> Log:
>> Simplify. NFC.
>>
>> Modified:
>>     lld/trunk/ELF/Writer.cpp
>>
>> Modified: lld/trunk/ELF/Writer.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=252716&r1=252715&r2=252716&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/ELF/Writer.cpp (original)
>> +++ lld/trunk/ELF/Writer.cpp Wed Nov 11 03:57:08 2015
>> @@ -554,8 +554,7 @@ template <class ELFT> void Writer<ELFT>:
>>    for (const std::unique_ptr<ObjectFile<ELFT>> &F :
>> Symtab.getObjectFiles())
>>      for (InputSectionBase<ELFT> *B : F->getSections())
>>        if (auto *S = dyn_cast_or_null<InputSection<ELFT>>(B))
>> -        if (S != &InputSection<ELFT>::Discarded)
>> -          if (S->isLive())
>> +        if (S != &InputSection<ELFT>::Discarded && S->isLive())
>>              scanRelocs(*S);
>
>
> Might just be the diff looking weird, but I assume this line needs to be
> re-indented ^ ?
>
>>
>>
>>    std::vector<DefinedCommon<ELFT> *> CommonSymbols;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>


More information about the llvm-commits mailing list