[PATCH] D13939: [archie-client][mips] Define NOREGEX macro since MUSL doesn't provide re_{comp, exec}().

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 02:14:59 PST 2015


vkalintiris added inline comments.

================
Comment at: MultiSource/Benchmarks/Prolangs-C/archie-client/Makefile:6-8
@@ -5,5 +5,5 @@
 # This test uses the deprecated re_comp functions.
 ifdef HAVE_RE_COMP
 PROG = archie
 endif
 
----------------
dsanders wrote:
> Shouldn't this disable the test if re_comp is unavailable? It should be defined/not-defined by the configure step.
We can't rely on the configuration script for this at the moment (see http://lists.llvm.org/pipermail/llvm-dev/2015-October/091758.html).

Even if the configure step was reliable, disabling the whole test, seems like an overkill to me. Given the transition to CMake, I suggest that we commit this and properly configure the test-suite for cross-compilation with CMake in the future.


http://reviews.llvm.org/D13939





More information about the llvm-commits mailing list