[PATCH] D14380: [ARM] Combine BFIs together

[silviu.baranga@arm.com via llvm-commits]

sbaranga added inline comments.

================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9067
@@ +9066,3 @@
+    APInt NewToMask, NewFromMask;
+    SDValue NewFrom = ParseBFI(V.getNode(), NewToMask, NewFromMask);
+    if (NewFrom != From) {
----------------
jmolloy wrote:
> I thought about it again and there's nothing stopping us looking through a BFI with a different base.
Ok, but I think we still need to set the CombinedToMask in this case (otherwise we might not detect some conflicts).


Repository:
  rL LLVM

http://reviews.llvm.org/D14380