[PATCH] D14380: [ARM] Combine BFIs together

[James Molloy via llvm-commits]

jmolloy marked 2 inline comments as done.

================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9046
@@ +9045,3 @@
+//
+// Neither A nor B must be zero.
+static bool BitsProperlyConcatenate(const APInt &A, const APInt &B) {
----------------
I was treating LastActiveBitInA and FirstActiveBitInB as numbering starting from the MSB. This was confusing, so I've swapped to LSB-based numbering.

================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9067
@@ +9066,3 @@
+    APInt NewToMask, NewFromMask;
+    SDValue NewFrom = ParseBFI(V.getNode(), NewToMask, NewFromMask);
+    if (NewFrom != From) {
----------------
I thought about it again and there's nothing stopping us looking through a BFI with a different base.


Repository:
  rL LLVM

http://reviews.llvm.org/D14380