[PATCH] D14401: [PGO] Make indexed value profile data more compact and add structural definitions for the data format

[Xinliang David Li via llvm-commits]

>
> Please switch over the value kinds here - that way we'll get a warning
> for missing switch cases if we add kinds and don't update this code.
>

Done.



>
> Might as well use /// so doxygen picks these comments up. Applies to the
> new structs as well..
>


Done.


> Please don't do this. Documentation in a comment is clearer than dead
> #if'd out code. OTOH, can this be simplified with the TrailingObjects
> template James introduced a while ago?
>

Removed it.

For a low level type related to disk layout, the simpler way is preferred.


thanks,

David

>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/3ddaa6ca/attachment.html>