[PATCH] D14401: [PGO] Make indexed value profile data more compact and add structural definitions for the data format

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 15:01:19 PST 2015


vsk added a comment.

It'd be nice to have blob testing done before a major release, but that sounds like a discussion for llvm-dev. Lgtm with a tiny nit.


================
Comment at: include/llvm/ProfileData/InstrProf.h:424
@@ +423,3 @@
+  // Since NumValueSites is greater than zero, there is at least one
+  // element inthe array.
+  uint8_t SiteCountArray[1];
----------------
nit: inthe -> in the


http://reviews.llvm.org/D14401





More information about the llvm-commits mailing list