[PATCH] D12781: PGO IR-level instrumentation infrastructure

[Sean Silva via llvm-commits]

On Fri, Nov 6, 2015 at 3:12 PM, Rong Xu <xur at google.com> wrote:

> xur updated this revision to Diff 39600.
> xur added a comment.
>
> Thanks Manman Ren and David Majnemer for the code review. I have
> integrated their feedbacks to the newly upload patch.
> The only thing I did not do is the "make_unque" suggestion by Manman. It
> seems to be a c++14 feature and I got an compile time error for that.
>

Use llvm::make_unique from llvm/ADT/STLExtras.h

-- Sean Silva


>
> I'll integrate David Li's feedback in a later patch.
>
> Thanks,
>
> -Rong
>
>
> http://reviews.llvm.org/D12781
>
> Files:
>   include/llvm/IR/DiagnosticInfo.h
>   include/llvm/InitializePasses.h
>   include/llvm/LinkAllPasses.h
>   include/llvm/Support/CFGMST.h
>   include/llvm/Transforms/Instrumentation.h
>   lib/IR/DiagnosticInfo.cpp
>   lib/Transforms/IPO/LLVMBuild.txt
>   lib/Transforms/Instrumentation/CMakeLists.txt
>   lib/Transforms/Instrumentation/Instrumentation.cpp
>   lib/Transforms/Instrumentation/LLVMBuild.txt
>   lib/Transforms/Instrumentation/PGOIRInstr.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/db7fb473/attachment.html>