<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 6, 2015 at 3:12 PM, Rong Xu <span dir="ltr"><<a href="mailto:xur@google.com" target="_blank">xur@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">xur updated this revision to Diff 39600.<br>
xur added a comment.<br>
<br>
Thanks Manman Ren and David Majnemer for the code review. I have integrated their feedbacks to the newly upload patch.<br>
The only thing I did not do is the "make_unque" suggestion by Manman. It seems to be a c++14 feature and I got an compile time error for that.<br></blockquote><div><br></div><div>Use llvm::make_unique from llvm/ADT/STLExtras.h</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
I'll integrate David Li's feedback in a later patch.<br>
<br>
Thanks,<br>
<br>
-Rong<br>
<span class=""><br>
<br>
<a href="http://reviews.llvm.org/D12781" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12781</a><br>
<br>
Files:<br>
  include/llvm/IR/DiagnosticInfo.h<br>
  include/llvm/InitializePasses.h<br>
  include/llvm/LinkAllPasses.h<br>
  include/llvm/Support/CFGMST.h<br>
</span>  include/llvm/Transforms/Instrumentation.h<br>
  lib/IR/DiagnosticInfo.cpp<br>
  lib/Transforms/IPO/LLVMBuild.txt<br>
  lib/Transforms/Instrumentation/CMakeLists.txt<br>
  lib/Transforms/Instrumentation/Instrumentation.cpp<br>
  lib/Transforms/Instrumentation/LLVMBuild.txt<br>
  lib/Transforms/Instrumentation/PGOIRInstr.cpp<br>
<br>
</blockquote></div><br></div></div>