[PATCH] D14464: Add discriminators for call instructions that are from the same line and same basic block.

[David Blaikie via llvm-commits]

On Nov 6, 2015 4:52 PM, "Paul Robinson via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:
>
> probinson added a comment.
>
> In http://reviews.llvm.org/D14464#284332, @dblaikie wrote:
>
> > Even with column info, its insufficient if both calls came from the same
> >  macro use:
> >
> > #define X f(); f()
> >  int main() {
> >
> >   X;
> >
> > }
> >
> > Both calls to 'f' will have the same line and column, the location of
the X
> >  use.
>
>
> Of course if the column numbers are the same, you need the discriminator.
The provided test case did not have that situation, which is why I asked.
You don't want to be chewing up extra space in the line table if you don't
need to.

Sure, agreed. Not sure if the current discriminators implementation already
has the smarts to dtrt whether column info is enabled or not. (Where 'the
right thing' is what you said: only adding discriminators when needed)

>
>
> http://reviews.llvm.org/D14464
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/230fc956/attachment.html>