[PATCH] D14464: Add discriminators for call instructions that are from the same line and same basic block.
Paul Robinson via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 6 16:52:41 PST 2015
probinson added a comment.
In http://reviews.llvm.org/D14464#284332, @dblaikie wrote:
> Even with column info, its insufficient if both calls came from the same
> macro use:
>
> #define X f(); f()
> int main() {
>
> X;
>
> }
>
> Both calls to 'f' will have the same line and column, the location of the X
> use.
Of course if the column numbers are the same, you need the discriminator. The provided test case did not have that situation, which is why I asked. You don't want to be chewing up extra space in the line table if you don't need to.
http://reviews.llvm.org/D14464
More information about the llvm-commits
mailing list