[PATCH] D14464: Add discriminators for call instructions that are from the same line and same basic block.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 16:44:16 PST 2015


Even with column info, its insufficient if both calls came from the same
macro use:

#define X f(); f()
int main() {
  X;
}

Both calls to 'f' will have the same line and column, the location of the X
use.
On Nov 6, 2015 2:37 PM, "Paul Robinson via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:

> probinson added a subscriber: probinson.
> probinson added a comment.
>
> Wouldn't you distinguish these by column number?  Discriminator is
> intended to be for paths that can't be distinguished solely by source
> location.
>
>
> http://reviews.llvm.org/D14464
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/82ac2e9d/attachment.html>


More information about the llvm-commits mailing list