<p dir="ltr">Even with column info, its insufficient if both calls came from the same macro use:</p>
<p dir="ltr">#define X f(); f()<br>
int main() {<br>
  X;<br>
}</p>
<p dir="ltr">Both calls to 'f' will have the same line and column, the location of the X use.</p>
<div class="gmail_quote">On Nov 6, 2015 2:37 PM, "Paul Robinson via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">probinson added a subscriber: probinson.<br>
probinson added a comment.<br>
<br>
Wouldn't you distinguish these by column number?  Discriminator is intended to be for paths that can't be distinguished solely by source location.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D14464" rel="noreferrer" target="_blank">http://reviews.llvm.org/D14464</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>