[PATCH] D14359: [elf2] Add support for R_X86_64_TLSLD.

[Michael Spencer via llvm-commits]

Bigcheese added inline comments.

================
Comment at: ELF/OutputSections.cpp:83
@@ -82,1 +82,3 @@
 
+template <class ELFT> uint32_t GotSection<ELFT>::addLocalModuleTlsIndex() {
+  Entries.push_back(nullptr);
----------------
rafael wrote:
> Will this also be used for global tls? Change the name if so.
No. Global Dynamic symbols can be handled by addEntry already. Just needs to check the symbol type.

================
Comment at: test/elf2/tls-dynamic.s:3
@@ +2,3 @@
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+// RUN: ld.lld2 -shared %t -o %tout
+// RUN: llvm-readobj -sections -relocations %tout | FileCheck %s
----------------
rafael wrote:
> When producing an executable gold produces no dynamic relocations. I understand that is just an optimization that we don't have yet.  To avoid changing this test is the future, can you change it to use -shared? With that you can also remove
> 
> 	​  .text
> 		​  .globl  _start
> 		​_start:
> 
It's already -shared, I'll remove the _start symbol.


http://reviews.llvm.org/D14359