[PATCH] D14359: [elf2] Add support for R_X86_64_TLSLD.

[Rui Ueyama via llvm-commits]

I'm out of office today. I'll review this in a few days. Sorry for the
delay.

On Fri, Nov 6, 2015 at 3:03 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> rafael added inline comments.
>
> ================
> Comment at: ELF/InputSection.cpp:96
> @@ +95,3 @@
> +      Target->relocateOne(
> +          Buf + RI.r_offset, BufEnd, Type, BaseAddr + RI.r_offset,
> +          Out<ELFT>::Got->getVA() + Out<ELFT>::LocalModuleTlsIndexOffset +
> ----------------
> Buf + RI.r_offset is now used 3 times is this function. Please factor it
> into a variable above, commit that and rebase.
>
> The same is true for  BaseAddr + RI.r_offset
>
> ================
> Comment at: ELF/OutputSections.cpp:83
> @@ -82,1 +82,3 @@
>
> +template <class ELFT> uint32_t GotSection<ELFT>::addLocalModuleTlsIndex()
> {
> +  Entries.push_back(nullptr);
> ----------------
> Will this also be used for global tls? Change the name if so.
>
>
> http://reviews.llvm.org/D14359
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/d4ca081e/attachment.html>