[PATCH] D13996: Fix SLPVectorizer commutativity reordering

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 09:44:55 PST 2015


> On 2015-Nov-06, at 09:42, Michael Zolotukhin <mzolotukhin at apple.com> wrote:
> 
> mzolotukhin added a comment.
> 
> Hi Mehdi,
> 
> Thanks for adding the tests! LGTM modulo a couple of nitpicks.
> 
> Michael
> 
> 
> ================
> Comment at: test/Transforms/SLPVectorizer/X86/commutativity.ll:1
> @@ +1,2 @@
> +; RUN: opt -slp-vectorizer %s -S | FileCheck %s
> +
> ----------------
> Should we do `opt < %s` instead of `opt %s` to avoid overwriting the input file?

`<%s` also prevents the filename from being included in the output,
which make the test results depend on the path to the build directory.



More information about the llvm-commits mailing list