[PATCH] D13996: Fix SLPVectorizer commutativity reordering

[Michael Zolotukhin via llvm-commits]

mzolotukhin added a comment.

Hi Mehdi,

Thanks for adding the tests! LGTM modulo a couple of nitpicks.

Michael


================
Comment at: test/Transforms/SLPVectorizer/X86/commutativity.ll:1
@@ +1,2 @@
+; RUN: opt -slp-vectorizer %s -S | FileCheck %s
+
----------------
Should we do `opt < %s` instead of `opt %s` to avoid overwriting the input file?

================
Comment at: test/Transforms/SLPVectorizer/X86/commutativity.ll:59-60
@@ +58,4 @@
+
+; Check that we correctly detects a splat/broadcast by levaraging the
+; commutativity propriety of `xor`.
+
----------------
Just noticed several typos here (and in the same comment in the previous test):
s/detects/detect/
s/levaraging/leveraging/
s/propriety/property/


http://reviews.llvm.org/D13996