[PATCH] D14199: [compiler-rt] [tsan] Unify aarch64 mapping

[Adhemerval Zanella via llvm-commits]

zatrazz added inline comments.

================
Comment at: lib/tsan/rtl/tsan_platform.h:137
@@ +136,3 @@
+extern uptr kHiAppMemEnd;
+extern uptr kAppMemMsk;
+extern uptr kAppMemXor;
----------------
dvyukov wrote:
> But can we have just global vars? It seems to be enough. The same generic functions will just operate with different values stores in the vars.
> 
> I am just frighten by the size of this change, amount of logical indirections and macros.
> 
We can, but it will be slower: every function transformation will require not only an indirection but also potentially memory reads to actually get the global variables value. The idea of the patch to create multiple functions is to try to minimize the performance hit this same indirection occurs by creating functions is fast as possible.


http://reviews.llvm.org/D14199