[PATCH] D14199: [compiler-rt] [tsan] Unify aarch64 mapping

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 04:33:59 PST 2015


dvyukov added inline comments.

================
Comment at: lib/tsan/rtl/tsan_platform.h:137
@@ +136,3 @@
+extern uptr kHiAppMemEnd;
+extern uptr kAppMemMsk;
+extern uptr kAppMemXor;
----------------
But can we have just global vars? It seems to be enough. The same generic functions will just operate with different values stores in the vars.

I am just frighten by the size of this change, amount of logical indirections and macros.



http://reviews.llvm.org/D14199





More information about the llvm-commits mailing list