[PATCH] D14237: [tsan] Port TSan interceptors on OS X

[Dmitry Vyukov via llvm-commits]

dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM if you agree with the nitpicks


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:337
@@ -325,1 +336,3 @@
 
+TSAN_INTERCEPTOR(void*, malloc, uptr size) {
+  if (cur_thread()->in_symbolizer)
----------------
Please move it back.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:716
@@ -694,3 +715,3 @@
 
-#if !SANITIZER_FREEBSD
+#if !SANITIZER_FREEBSD && !SANITIZER_MAC
 TSAN_INTERCEPTOR(void*, mmap64, void *addr, long_t sz, int prot,
----------------
I think

#if SANITIZER_LINUX

will look move reasonable here now.


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:746
@@ -724,3 +745,3 @@
 
-#if !SANITIZER_FREEBSD
+#if !SANITIZER_FREEBSD && !SANITIZER_MAC
 TSAN_INTERCEPTOR(void*, memalign, uptr align, uptr sz) {
----------------
same

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:768
@@ -744,3 +767,3 @@
 
-#if !SANITIZER_FREEBSD
+#if !SANITIZER_FREEBSD && !SANITIZER_MAC
 TSAN_INTERCEPTOR(void*, pvalloc, uptr sz) {
----------------
same here and below


http://reviews.llvm.org/D14237