[PATCH] D14237: [tsan] Port TSan interceptors on OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 04:00:43 PST 2015


dvyukov added a comment.

> Dima, do you think we might want to move the Linux-specific interceptors into a separate file?


I am fine with having it all in a single file. The files will be huge anyway, so the only way of working with them is searching. Searching in a single file is simpler. E.g. where will you put pthread_spin_lock and how will you figure out where to search for it (it is linux and freebsd but not darwin, so not even "posix")?


http://reviews.llvm.org/D14237





More information about the llvm-commits mailing list