[PATCH] D14167: [lld][elf2] Generate PT_TLS.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:674
@@ +673,3 @@
+  Elf_Phdr TlsPhdr;
+  TlsPhdr.p_vaddr = 0;
+  uintX_t ThreadBSSOffset = 0;
----------------
Bigcheese wrote:
> ruiu wrote:
> > Do we need this? Isn't an Elf_Phdr zero-initialized?
> There's no explicit zero init, and I'm pretty sure default-initialization here does nothing.
I'd zero out all fields using memset.


http://reviews.llvm.org/D14167