[PATCH] D14167: [lld][elf2] Generate PT_TLS.

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 15:46:40 PST 2015


Bigcheese added inline comments.

================
Comment at: ELF/Writer.cpp:674
@@ +673,3 @@
+  Elf_Phdr TlsPhdr;
+  TlsPhdr.p_vaddr = 0;
+  uintX_t ThreadBSSOffset = 0;
----------------
ruiu wrote:
> Do we need this? Isn't an Elf_Phdr zero-initialized?
There's no explicit zero init, and I'm pretty sure default-initialization here does nothing.


http://reviews.llvm.org/D14167





More information about the llvm-commits mailing list