[PATCH] D14171: [ELF2] merge-string.s test fixed for win32 configuraton.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 07:26:39 PDT 2015


grimar added a comment.

In http://reviews.llvm.org/D14171#277730, @ruiu wrote:

> I think we should change the type used for the pair to size_t instead of changing the type used here to uintX_t. StringTableBuilder cannot build a table that's larger than size_t's max, so converting size_t to a possibly larger type here does not make much sense.


As for me it is an issue of StringTableBuilder. Which uses template class DenseMap<StringRef, size_t> that has size_t as parameter for size type, but StringTableBuilder itself does not has template argument to set its size type from outside.


http://reviews.llvm.org/D14171





More information about the llvm-commits mailing list