[PATCH] D14171: [ELF2] merge-string.s test fixed for win32 configuraton.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 06:21:12 PDT 2015


ruiu added a comment.

I think we should change the type used for the pair to size_t instead of changing the type used here to uintX_t. StringTableBuilder cannot build a table that's larger than size_t's max, so converting size_t to a possibly larger type here does not make much sense.


http://reviews.llvm.org/D14171





More information about the llvm-commits mailing list